Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(directus plugin): prefer session over json mode #103

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ComfortablyCoding
Copy link
Contributor

@ComfortablyCoding ComfortablyCoding commented Jul 31, 2024

Scope

What's changed:

  • Updated the directus client side plugin to use the recommended session mode for requests

Potential Risks / Drawbacks

  • cross-domain usage can break if *_cookie_* rules are not correctly set.

Review Notes / Questions

  • N/A

Fixes: #98

@ComfortablyCoding ComfortablyCoding added the enhancement New feature or request label Jul 31, 2024
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agency-os ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 0:22am

Copy link

@w0kyj w0kyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ComfortablyCoding ComfortablyCoding merged commit 9247d79 into main Aug 1, 2024
2 of 4 checks passed
@ComfortablyCoding ComfortablyCoding deleted the issue-98 branch August 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Load Images in Portal Due to 403 Error Despite Administrator Access
2 participants